lidavidm commented on code in PR #679:
URL: https://github.com/apache/arrow-adbc/pull/679#discussion_r1202439648
##########
c/validation/adbc_validation.cc:
##########
@@ -508,8 +508,8 @@ void ConnectionTest::TestMetadataGetObjectsDbSchemas() {
// type: list<table_schema>
struct ArrowArrayView* db_schema_tables_list =
catalog_db_schemas->children[1];
- ASSERT_FALSE(ArrowArrayViewIsNull(catalog_db_schemas_list, row))
- << "Row " << row << " should have non-null catalog_db_schemas";
+ // ASSERT_FALSE(ArrowArrayViewIsNull(catalog_db_schemas_list, row))
Review Comment:
The intent is that if you request the schemas, it should come back as a
(possibly empty) list, not null.
##########
c/driver/postgresql/connection.cc:
##########
@@ -249,8 +282,33 @@ AdbcStatusCode PostgresConnectionGetObjectsImpl(
ArrowArrayAppendString(catalog_name_col,
ArrowCharView(db_name)), error);
if (depth == ADBC_OBJECT_DEPTH_CATALOGS) {
CHECK_NA(INTERNAL, ArrowArrayAppendNull(catalog_db_schemas_col, 1),
error);
- } else {
- return ADBC_STATUS_NOT_IMPLEMENTED;
+ } else if (!db_schema ||
Review Comment:
That test expects a non-NULL, but empty, list of schemas back. Obviously,
if the schema exists, we should return it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
