WillAyd commented on code in PR #679:
URL: https://github.com/apache/arrow-adbc/pull/679#discussion_r1195785107
##########
c/driver/postgresql/connection.cc:
##########
@@ -182,7 +216,12 @@ AdbcStatusCode PostgresConnectionGetObjectsImpl(
if (depth == ADBC_OBJECT_DEPTH_CATALOGS) {
CHECK_NA(INTERNAL, ArrowArrayAppendNull(catalog_db_schemas_col, 1),
error);
} else {
- return ADBC_STATUS_NOT_IMPLEMENTED;
+ if (depth >= ADBC_OBJECT_DEPTH_DB_SCHEMAS) {
+ RAISE_ADBC(PostgresConnectionGetSchemasImpl(conn, depth,
Review Comment:
> So to iterate "catalog_db_schema", you would use nanoarrow to get the
array offsets of element 0 in the catalog_db_schema array, which would give you
a slice of the child array to iterate through...
Great thanks for the guidance. I see nanoarrow has
`ArrowArrayViewUnionChildOffset` but didn't see anything similar for Lists
(though I think the member access would be the same as far as lists go). Think
its worth trying to upstream that function for lists first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
