rtpsw commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1196647245
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -601,6 +603,7 @@ std::shared_ptr<Table> GetOutputTableForAggregateCase(
std::shared_ptr<acero::ExecPlan> PlanFromAggregateCase(
const AggregateTestCase& test_case, std::shared_ptr<Table>* output_table,
bool with_keys) {
+ static ExecContext ctx_for_ordered;
Review Comment:
This `static ExecContext` is code I've seen elsewhere in Arrow. There's no
need for `shared_ptr` to wrap it (like using some `Make` function), because a
non-static `ExecContext` would do. It's just that a static one won't get
recreated with each invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
