pitrou commented on code in PR #702:
URL: https://github.com/apache/arrow-adbc/pull/702#discussion_r1204561705


##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyx:
##########
@@ -498,6 +511,11 @@ cdef class ArrowArrayStreamHandle:
         """The address of the ArrowArrayStream."""
         return <uintptr_t> &self.stream
 
+    def _to_capsule(self):
+        return cpython.PyCapsule_New(
+            &self.stream, 'arrowarraystream', pycapsule_stream_deleter

Review Comment:
   Keeping the Python object alive from the capsule would probably be harder?
   
   Keep in mind any producer of the capsule format will need to reimplement its 
own destructor function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to