westonpace commented on code in PR #35565:
URL: https://github.com/apache/arrow/pull/35565#discussion_r1205252631
##########
cpp/src/arrow/util/align_util.h:
##########
@@ -82,29 +101,109 @@ ARROW_EXPORT bool CheckAlignment(const Array& array,
int64_t alignment);
// of the constituent objects during the EnsureAlignment function where certain
// objects can be ignored for further checking if we already know that they are
// completely aligned.
+
+/// \brief calculate which (if any) chunks in a chunked array are unaligned
+/// \param array the array to check
+/// \param alignment the alignment to check for
+/// \param needs_alignment an output vector that will store the results of the
check
+/// it must be set to a valid vector. Extra elements will be added to
the end
+/// of the vector for each chunk that is checked. `true` will be
stored if
+/// the chunk is unaligned.
+/// \param offset an optional offset to specify which chunk to start checking
at
Review Comment:
I changed the wording to:
```
/// \param offset the index of the chunk to start checking
```
##########
cpp/src/arrow/util/align_util.h:
##########
@@ -70,8 +70,27 @@ inline BitmapWordAlignParams BitmapWordAlign(const uint8_t*
data, int64_t bit_of
namespace util {
// Functions to check if the provided Arrow object is aligned by the specified
alignment
+
+/// \brief if this is specified in one of the CheckAlignment or
EnsureAlignment functions
+///
+/// then the function will ensure each buffer is suitably aligned for the data
type of the
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
