westonpace commented on code in PR #35565:
URL: https://github.com/apache/arrow/pull/35565#discussion_r1205254683
##########
cpp/src/arrow/util/align_util.h:
##########
@@ -70,8 +70,27 @@ inline BitmapWordAlignParams BitmapWordAlign(const uint8_t*
data, int64_t bit_of
namespace util {
// Functions to check if the provided Arrow object is aligned by the specified
alignment
+
+/// \brief if this is specified in one of the CheckAlignment or
EnsureAlignment functions
+///
+/// then the function will ensure each buffer is suitably aligned for the data
type of the
+/// array. For example, given an int32 buffer the validity buffer must be a
multiple of 8
+/// and the values buffer must be a multiple of 32. Given a large_string
buffer the
+/// validity buffer and values buffers must be multiples of 8 and the offsets
buffer must
+/// be a multiple of 64.
+constexpr int64_t kValueAlignment = -3;
+
+/// \brief calculate if the buffer's address is a multiple of `alignment`
+/// \param buffer the buffer to check
+/// \param alignment the alignment to check for
Review Comment:
I changed all of these to:
```
/// \param alignment the alignment (in bytes) to check for
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
