mustafasrepo commented on code in PR #6445:
URL: https://github.com/apache/arrow-datafusion/pull/6445#discussion_r1206568695
##########
datafusion/core/tests/dataframe_functions.rs:
##########
@@ -155,11 +155,11 @@ async fn test_fn_approx_median() -> Result<()> {
let expr = approx_median(col("b"));
let expected = vec![
- "+----------------------+",
- "| APPROXMEDIAN(test.b) |",
- "+----------------------+",
- "| 10 |",
- "+----------------------+",
+ "+-----------------------+",
Review Comment:
As part of this PR, I have added `convert_camel_to_upper_snake` util for
displaying Aggregate functions. Their display name is automatically,
calculated from struct name. Hence display name of some of the existing
aggregators is changed(such as `APPROXMEDIAN` became `APPROX_MEDIAN`,
`ARRAYAGG` became `ARRAY_AGG`, etc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
