mustafasrepo commented on code in PR #6445:
URL: https://github.com/apache/arrow-datafusion/pull/6445#discussion_r1207207062
##########
datafusion/expr/src/aggregate_function.rs:
##########
@@ -79,7 +84,9 @@ pub enum AggregateFunction {
impl fmt::Display for AggregateFunction {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
// uppercase of the debug.
- write!(f, "{}", format!("{self:?}").to_uppercase())
+ // Convert Camel form to uppercase snake
+ // such as FirstValue => FIRST_VALUE
+ write!(f, "{}", convert_camel_to_upper_snake(format!("{self:?}")))
}
Review Comment:
I think, your suggestion is better. By this way, we can avoid overfitting
enum name convention. Also, having explicit match, helps with debugging also. I
will add your suggestion to this Pr also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
