mustafasrepo commented on code in PR #6445: URL: https://github.com/apache/arrow-datafusion/pull/6445#discussion_r1207223843
########## datafusion/core/tests/sqllogictests/test_files/window.slt: ########## @@ -3017,6 +3017,13 @@ SELECT a, b, c, 0 0 3 11 96 11 2 10 36 10 36 11 5 11 9 0 0 4 9 72 9 NULL 14 45 14 45 9 4 9 9 +#fn aggregate order by with window frame +# In window expressions, aggregate functions should not have an ordering requirement, such requirements +# should be defined in the window frame. Therefore, the query below should generate an error. Note that +# PostgreSQL also behaves this way. +statement error DataFusion error: Error during planning: Aggregate ORDER BY is not implemented for window functions +SELECT SUM(inc_col ORDER BY a DESC) OVER() as last + FROM annotated_data_infinite2 Review Comment: I added a test for this use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
