jackwener commented on code in PR #6414:
URL: https://github.com/apache/arrow-datafusion/pull/6414#discussion_r1209435718


##########
datafusion/core/tests/sqllogictests/test_files/predicates.slt:
##########
@@ -249,6 +249,37 @@ SELECT * FROM test WHERE column1 IN ('foo', 'Bar', 'fazzz')
 foo
 fazzz
 
+
+# Test logical plan simplifies large OR chains

Review Comment:
   We can add more case about `large or` to cover up other shape expression 
tree.
   like 
   ```
      /     \
    /  \    /  \
   e1 e2    e3 e4
   ```
   current expression tree all is `left deep tree`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to