aprimadi commented on code in PR #6414:
URL: https://github.com/apache/arrow-datafusion/pull/6414#discussion_r1209440108
##########
benchmarks/expected-plans/q12.txt:
##########
@@ -7,7 +7,7 @@
| | Projection: lineitem.l_shipmode,
orders.o_orderpriority
|
| | Inner Join: lineitem.l_orderkey = orders.o_orderkey
|
| | Projection: lineitem.l_orderkey,
lineitem.l_shipmode
|
-| | Filter: (lineitem.l_shipmode = Utf8("SHIP") OR
lineitem.l_shipmode = Utf8("MAIL")) AND lineitem.l_commitdate <
lineitem.l_receiptdate AND lineitem.l_shipdate < lineitem.l_commitdate AND
lineitem.l_receiptdate >= Date32("8766") AND lineitem.l_receiptdate <
Date32("9131")
|
+| | Filter: (lineitem.l_shipmode = Utf8("MAIL") OR
lineitem.l_shipmode = Utf8("SHIP")) AND lineitem.l_commitdate <
lineitem.l_receiptdate AND lineitem.l_shipdate < lineitem.l_commitdate AND
lineitem.l_receiptdate >= Date32("8766") AND lineitem.l_receiptdate <
Date32("9131")
|
Review Comment:
I think to be able to do that we need to do merging and expanding of OR /
LIST statements in one pass. This seems rather complicated to me at the moment.
I'll check`EliminateDuplicatedExpr` for some inspiration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
