aprimadi commented on code in PR #6414:
URL: https://github.com/apache/arrow-datafusion/pull/6414#discussion_r1209447796
##########
benchmarks/expected-plans/q12.txt:
##########
@@ -7,7 +7,7 @@
| | Projection: lineitem.l_shipmode,
orders.o_orderpriority
|
| | Inner Join: lineitem.l_orderkey = orders.o_orderkey
|
| | Projection: lineitem.l_orderkey,
lineitem.l_shipmode
|
-| | Filter: (lineitem.l_shipmode = Utf8("SHIP") OR
lineitem.l_shipmode = Utf8("MAIL")) AND lineitem.l_commitdate <
lineitem.l_receiptdate AND lineitem.l_shipdate < lineitem.l_commitdate AND
lineitem.l_receiptdate >= Date32("8766") AND lineitem.l_receiptdate <
Date32("9131")
|
+| | Filter: (lineitem.l_shipmode = Utf8("MAIL") OR
lineitem.l_shipmode = Utf8("SHIP")) AND lineitem.l_commitdate <
lineitem.l_receiptdate AND lineitem.l_shipdate < lineitem.l_commitdate AND
lineitem.l_receiptdate >= Date32("8766") AND lineitem.l_receiptdate <
Date32("9131")
|
Review Comment:
But yeah it won't preserve ordering of complex OR statements like: A OR (B
OR C). It will just translates this into A OR B OR C.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
