aprimadi commented on code in PR #6414:
URL: https://github.com/apache/arrow-datafusion/pull/6414#discussion_r1210455190
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -549,6 +555,55 @@ mod tests {
Ok(())
}
+ struct Line(Option<usize>);
+
+ impl fmt::Display for Line {
+ fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+ match self.0 {
+ None => write!(f, " "),
+ Some(idx) => write!(f, "{:<4}", idx + 1),
+ }
+ }
+ }
+
+ fn assert_text_eq(expected: String, actual: String) {
Review Comment:
Since @liurenjie1024 is working on removing these tests from the benchmark,
perhaps we should just remove this? I keep this change contained in 1 commit so
removing it should be as simple as reverting a commit.
The sqllogictests may benefit from adding fancier diff 🤔 but it's not a
concern of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
