arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1213205407
##########
cpp/src/parquet/types.h:
##########
@@ -64,8 +64,12 @@ struct Type {
DOUBLE = 5,
BYTE_ARRAY = 6,
FIXED_LEN_BYTE_ARRAY = 7,
+
+ // This parquet type does not actually exist (AFAIK) and is used to
+ // create proper type traits
+ LARGE_BYTE_ARRAY = 8,
Review Comment:
If the above is correct, `TypedRecordReader` presents a challenge. It relies
on `EncodingTraits<>::Accumulator` to get the builder. Since we no longer have
the `parquet::Type::LARGE_BYTE_ARRAY`, there is no way to select the
`LargeBinaryBuilder` using it.
Not only that, but there are other dependencies on `EncondingTraits` like
the `ArrowType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]