emkornfield commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1215716146
##########
cpp/src/parquet/arrow/schema_internal.h:
##########
@@ -30,22 +30,27 @@ namespace arrow {
using ::arrow::Result;
Result<std::shared_ptr<::arrow::DataType>> FromByteArray(const LogicalType&
logical_type);
+Result<std::shared_ptr<::arrow::DataType>> FromLargeByteArray(const
LogicalType& logical_type);
+
Result<std::shared_ptr<::arrow::DataType>> FromFLBA(const LogicalType&
logical_type,
int32_t physical_length);
Result<std::shared_ptr<::arrow::DataType>> FromInt32(const LogicalType&
logical_type);
Result<std::shared_ptr<::arrow::DataType>> FromInt64(const LogicalType&
logical_type);
Result<std::shared_ptr<::arrow::DataType>> GetArrowType(Type::type
physical_type,
const LogicalType&
logical_type,
- int type_length);
+ int type_length,
+ bool
use_binary_large_variant = false);
Review Comment:
if possible it would be good to avoid default parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
