comphead commented on code in PR #6522:
URL: https://github.com/apache/arrow-datafusion/pull/6522#discussion_r1214657767
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -522,6 +522,13 @@ fn date_bin_impl(
let (stride, stride_fn) = stride.bin_fn();
+ // Return error if stride is 0
+ if stride == 0 {
Review Comment:
> Thanks @comphead and @alamb, I have addressed your comments.
>
> @comphead : we supported interval `month` and `year` interval in [this
PR](https://github.com/apache/arrow-datafusion/pull/5982)
Thanks I'll check that, PG doesn't support strides as months and larger,
need to check what is the reason for that, as we consider PG behavior as an
example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
