alamb commented on code in PR #6522:
URL: https://github.com/apache/arrow-datafusion/pull/6522#discussion_r1214665889
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -522,6 +522,13 @@ fn date_bin_impl(
let (stride, stride_fn) = stride.bin_fn();
+ // Return error if stride is 0
+ if stride == 0 {
Review Comment:
Using months as strides is significantly more complicated because they are
not a fixed size (sometimes 28 days, sometimes 29, 30 or 31, etc)
Binning by months / years was important to us in IOx so @NGA-TRAN
implemented that logic for
https://github.com/apache/arrow-datafusion/issues/5689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
