rtpsw commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1220182605
##########
cpp/src/arrow/util/thread_pool.h:
##########
@@ -301,8 +301,10 @@ class ARROW_EXPORT SerialExecutor : public Executor {
/// approach is to use a stop token to cause the generator to exhaust early.
template <typename T>
static Iterator<T> IterateGenerator(
- internal::FnOnce<Result<std::function<Future<T>()>>(Executor*)>
initial_task) {
+ internal::FnOnce<Result<std::function<Future<T>()>>(Executor*)>
initial_task,
+ internal::SerialExecutor** serial_executor_out = NULLPTR) {
Review Comment:
It is a bit strange. At least so far I didn't find a better way to expose,
given that the [`SerialExecutor` constructor is
private](https://github.com/apache/arrow/blob/daacbcc4c5f0e435b2158896584a4385dbf38986/cpp/src/arrow/util/thread_pool.h#L370-L371).
I needed to expose it to [send the stop-token to
it](https://github.com/apache/arrow/pull/35953/files#diff-70e843181eb977ed11ad131f79a0f54a0bf9e30a0cb752d440658ee0cc16cc34R1076).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
