icexelloss commented on PR #35953: URL: https://github.com/apache/arrow/pull/35953#issuecomment-1580773844
Yaron - where are a couple PR/discussion to fix cancellation in serial execution (or just execution in general?) and I think we should consolidate the discussion first, figure out what is needed to be done, instead of merging PR piece by piece without understanding the large picture. Is there a place we can consolidate discussion and figure next steps? On Wed, Jun 7, 2023 at 1:27 AM rtpsw ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In cpp/src/arrow/acero/exec_plan.h > <https://github.com/apache/arrow/pull/35953#discussion_r1220870027>: > > > @@ -602,6 +603,9 @@ struct ARROW_ACERO_EXPORT QueryOptions { > /// If this field is not set then it will be treated as kWarn unless overridden > /// by the ACERO_ALIGNMENT_HANDLING environment variable > std::optional<UnalignedBufferHandling> unaligned_buffer_handling; > + > + /// \brief An optional stop-token for the query. Defaults to unstoppable. > + StopToken stop_token = StopToken::Unstoppable(); > > I imagine it's possible to make StopProducing be sufficient to shut down > the plan even if it is serially executing, based on the facilities in this > PR. However, there may be unforeseen interactions so I'd suggest deferring > this to a separate discussion/issue. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/35953#discussion_r1220870027>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGBXLBRSBZOEEMXOB2JFU3XKAGK5ANCNFSM6AAAAAAY4VPKU4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
