icexelloss commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1220346253
##########
cpp/src/arrow/acero/exec_plan.h:
##########
@@ -602,6 +603,9 @@ struct ARROW_ACERO_EXPORT QueryOptions {
/// If this field is not set then it will be treated as kWarn unless
overridden
/// by the ACERO_ALIGNMENT_HANDLING environment variable
std::optional<UnalignedBufferHandling> unaligned_buffer_handling;
+
+ /// \brief An optional stop-token for the query. Defaults to unstoppable.
+ StopToken stop_token = StopToken::Unstoppable();
Review Comment:
Hmm..OK. It feels strange that StopProducing does not work with Serial
execution and we need a different way to stop an execution with serial
execution. I would like to understand (1) why serial execution doesn't work
with StopProducing now and (2) why we cannot make `StopProducing` to work (with
serial execution.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
