westonpace commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1221591136
##########
cpp/src/arrow/acero/exec_plan.h:
##########
@@ -602,6 +603,9 @@ struct ARROW_ACERO_EXPORT QueryOptions {
/// If this field is not set then it will be treated as kWarn unless
overridden
/// by the ACERO_ALIGNMENT_HANDLING environment variable
std::optional<UnalignedBufferHandling> unaligned_buffer_handling;
+
+ /// \brief An optional stop-token for the query. Defaults to unstoppable.
+ StopToken stop_token = StopToken::Unstoppable();
Review Comment:
I think both the stop token and `StopProducing` were valid approaches we
could have taken. I don't think we actually need to do both. Since we spoke
we made a lot more progress on `StopProducing` and I have gained more
confidence in that approach. I'd prefer to stick purely with `StopProducing`
if possible. As such, I think I am -1 on this PR at the moment, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
