tustvold commented on code in PR #4381:
URL: https://github.com/apache/arrow-rs/pull/4381#discussion_r1222994776
##########
arrow-array/src/array/binary_array.rs:
##########
@@ -217,84 +217,10 @@ where
}
}
-/// An array of `[u8]` using `i32` offsets
-///
-/// The byte length of each element is represented by an i32.
Review Comment:
Perhaps I could add a mix of StringArray and BinaryArray to the
GenericBinaryArray examples would that aleviate your concern?
The major thing I'm trying to avoid is people look at the docs for
`StringArray`, which are always going to be because rust docs doesn't show the
functions implemented for `GenericByteArray`, and then get stuck
The fact this drastically cuts down on maintenance overheads is largely a
happy accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
