alamb commented on code in PR #4381:
URL: https://github.com/apache/arrow-rs/pull/4381#discussion_r1223042952


##########
arrow-array/src/array/binary_array.rs:
##########
@@ -217,84 +217,10 @@ where
     }
 }
 
-/// An array of `[u8]` using `i32` offsets
-///
-/// The byte length of each element is represented by an i32.

Review Comment:
   > The major thing I'm trying to avoid is people look at the docs for 
StringArray, which are always going to be incomplete because rust docs doesn't 
show the functions implemented for GenericByteArray, and then get stuck
   
   Maybe we can add a note at the top of each typedef saying something like
   
   "Note this is a typedef, see the [`GenericBinaryArray`] for available methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to