alamb commented on code in PR #4381:
URL: https://github.com/apache/arrow-rs/pull/4381#discussion_r1223044257
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -37,8 +37,8 @@ use std::sync::Arc;
/// # Example: From a Vec
///
/// ```
-/// # use arrow_array::{Array, GenericByteArray, types::Utf8Type};
-/// let arr: GenericByteArray<Utf8Type> = vec!["hello", "world", ""].into();
+/// # use arrow_array::{Array, StringArray};
Review Comment:
I think this is now even more confusing at it doesn't show creating a
`StringAray` from `Vec<Option<&str>>`
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -200,8 +200,8 @@ pub use crate::types::ArrowPrimitiveType;
/// # Example: From a Vec
///
/// ```
-/// # use arrow_array::{Array, PrimitiveArray, types::Int32Type};
-/// let arr: PrimitiveArray<Int32Type> = vec![1, 2, 3, 4].into();
+/// # use arrow_array::{Array, Int32Array};
Review Comment:
similarly the use of different typedefs here I think will be very confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
