rtpsw commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1228704935
##########
cpp/src/arrow/util/thread_pool.h:
##########
@@ -301,8 +301,10 @@ class ARROW_EXPORT SerialExecutor : public Executor {
/// approach is to use a stop token to cause the generator to exhaust early.
template <typename T>
static Iterator<T> IterateGenerator(
- internal::FnOnce<Result<std::function<Future<T>()>>(Executor*)>
initial_task) {
+ internal::FnOnce<Result<std::function<Future<T>()>>(Executor*)>
initial_task,
+ internal::SerialExecutor** serial_executor_out = NULLPTR) {
Review Comment:
That sounds right though an additional point is that `Close` hanged in the
loop for draining the remaining batches, so the destructor was never reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
