rtpsw commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1231853763
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -1001,18 +1000,24 @@ struct BatchConverter {
Result<AsyncGenerator<std::shared_ptr<RecordBatch>>>
DeclarationToRecordBatchGenerator(
Declaration declaration, QueryOptions options,
- ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema) {
+ ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema,
+ std::shared_ptr<ExecPlan>* out_plan) {
Review Comment:
What is the policy for documenting arguments? Most arguments are not
documented, especially in internal functions, and in many cases their meaning
is clear. I think this is the case here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
