rtpsw commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1235717729
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -951,7 +951,6 @@ struct BatchConverter {
if (exec_plan->finished().is_finished()) {
return;
}
- exec_plan->StopProducing();
Review Comment:
Reinstating this invocation requires a guarantee that
`ExecPlan::StopProducing()` is idempotent, otherwise if `PlanReader::Close()`
occurs then the invocation here which must occur as well may misbehave. I don't
see this guarantee in the documentation. @westonpace, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
