mapleFU commented on code in PR #35989:
URL: https://github.com/apache/arrow/pull/35989#discussion_r1237561942
##########
cpp/src/parquet/statistics.cc:
##########
@@ -610,8 +629,12 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
if (HasNullCount()) {
s.set_null_count(this->null_count());
}
- // num_values_ is reliable and it means number of non-null values.
- s.all_null_value = num_values_ == 0;
+ if (HasNullCount()) {
Review Comment:
This refactor is a bit tricky. When `ColumnChunkMetadata` read a statistics
from thrift, and if the thrift not have `null_count`, the `num_values` would be
wrong. And in C++ Parquet, we'll never meet this case, because writer always
has `has_null_count_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
