mapleFU commented on code in PR #35989:
URL: https://github.com/apache/arrow/pull/35989#discussion_r1242452436
##########
cpp/src/parquet/statistics.cc:
##########
@@ -627,7 +640,12 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
T min_;
T max_;
::arrow::MemoryPool* pool_;
- int64_t num_values_ = 0; // # of non-null values.
+ // # of non-null values.
+ // num_values_ would be reliable when has_null_count_,
+ // if it's created from a page thrift statistics, and statistics
+ // doesn't have null_count, but page has null data, `num_values_`
+ // would be equal to value including nulls.
Review Comment:
Tried it but maybe I'm not good for docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
