mapleFU commented on code in PR #35989:
URL: https://github.com/apache/arrow/pull/35989#discussion_r1238768978
##########
cpp/src/parquet/statistics.cc:
##########
@@ -610,8 +629,12 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
if (HasNullCount()) {
s.set_null_count(this->null_count());
}
- // num_values_ is reliable and it means number of non-null values.
- s.all_null_value = num_values_ == 0;
+ if (HasNullCount()) {
Review Comment:
Can a `!metadata.statistics.__isset.null_count` might means:
1. The underlying data has null
2. But it doesn't write it into statistics
If it can, when `!metadata.statistics.__isset.null_count`,
`metadata.num_values - metadata.statistics.null_count` cannot represent the
non-null count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
