kou commented on code in PR #36228:
URL: https://github.com/apache/arrow/pull/36228#discussion_r1237889042
##########
cpp/src/arrow/filesystem/gcsfs_internal.h:
##########
@@ -30,6 +32,15 @@
namespace arrow {
namespace fs {
+struct GcsCredentialsHolder {
Review Comment:
```suggestion
struct ARROW_EXPORT GcsCredentialsHolder {
```
##########
cpp/src/arrow/filesystem/gcsfs_internal.h:
##########
@@ -53,6 +64,8 @@ ARROW_EXPORT Result<std::shared_ptr<const KeyValueMetadata>>
FromObjectMetadata(
ARROW_EXPORT std::int64_t Depth(std::string_view path);
+google::cloud::Options AsGoogleCloudOptions(const GcsOptions& options);
Review Comment:
```suggestion
ARROW_EXPORT google::cloud::Options AsGoogleCloudOptions(const GcsOptions&
options);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
