coryan commented on code in PR #36228:
URL: https://github.com/apache/arrow/pull/36228#discussion_r1237938323
##########
cpp/src/arrow/filesystem/gcsfs_internal.h:
##########
@@ -30,6 +32,15 @@
namespace arrow {
namespace fs {
+struct GcsCredentialsHolder {
Review Comment:
I am not sure we want to do this. That symbol was not exported before, and
was not part of the public API:
https://github.com/apache/arrow/blob/cd6b2b5dca468cee6704ade4ce539c0a09874607/cpp/src/arrow/filesystem/gcsfs.cc#L38-L43
arguably it should live in `arrow::fs::internal`. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
