coryan commented on code in PR #36228:
URL: https://github.com/apache/arrow/pull/36228#discussion_r1246660262
##########
cpp/src/arrow/filesystem/gcsfs.h:
##########
@@ -77,6 +83,13 @@ struct ARROW_EXPORT GcsOptions {
/// This will be ignored if non-empty metadata is passed to OpenOutputStream.
std::shared_ptr<const KeyValueMetadata> default_metadata;
+ /// \brief The project to use for creating buckets.
+ ///
+ /// If not set, the library uses the GOOGLE_CLOUD_PROJECT environment
+ /// variable. Most I/O operations do not need a project id, only applications
+ /// that create new buckets need a project id.
+ std::optional<std::string> project_id;
Review Comment:
You are probably right. There is a difference between "not set" (which
implies "use the `GOOGLE_CLOUD_PROJECT` environment variable") and "set to
empty" (which implies "ignore the environment variable and use the empty
string"). Is this distinction useful? Arguably not.
I am working on the Python fixes today, I can change this to `std::string`
if you think it is best to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
