lidavidm commented on code in PR #765:
URL: https://github.com/apache/arrow-adbc/pull/765#discussion_r1238605416


##########
adbc.h:
##########
@@ -1380,6 +1827,67 @@ AdbcStatusCode AdbcConnectionGetTableTypes(struct 
AdbcConnection* connection,
                                            struct ArrowArrayStream* out,
                                            struct AdbcError* error);
 
+/// \brief Get a view of types supported by the database.
+///
+/// The result is an Arrow schema with one field per type.  The field name is
+/// the database's name for the type, and the field type is the driver's
+/// mapping of the database type to an Arrow type.

Review Comment:
   Perhaps an unsatisfactory answer, but this is based on the database's idea 
of types, so not every Arrow type is necessarily represented. However, I'll dig 
up concrete examples of what happens with decimal/timestamp types in databases.
   
   (Timezone handling, though, is a mess, and I'll point out that e.g. Postgres 
and SQL Server just have naive timestamps + UTC timestamps, with the timezone 
being purely a display concept that is set on the fly)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to