pitrou commented on code in PR #36067:
URL: https://github.com/apache/arrow/pull/36067#discussion_r1238644123
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc:
##########
@@ -91,35 +91,52 @@ static void IsInStringLargeSet(benchmark::State& state) {
}
static void IndexInInt8SmallSet(benchmark::State& state) {
- SetLookupBenchmarkNumeric<Int8Type>(state, "index_in_meta_binary",
state.range(0));
+ SetLookupBenchmarkNumeric<Int8Type>(state, "index_in_meta_binary",
state.range(0),
+ 1 << 18);
Review Comment:
Hmm, can we avoid the repeated hardcoded value?
You could define a constant such as `constexpr int64
kArrayLengthWithSmallSet = 1 << 18`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
