pitrou commented on code in PR #36067: URL: https://github.com/apache/arrow/pull/36067#discussion_r1238646880
########## cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc: ########## @@ -134,10 +151,12 @@ BENCHMARK(IndexInInt8SmallSet)->RangeMultiplier(4)->Range(2, 8); BENCHMARK(IndexInInt16SmallSet)->RangeMultiplier(4)->Range(2, 64); BENCHMARK(IndexInInt32SmallSet)->RangeMultiplier(4)->Range(2, 64); BENCHMARK(IndexInInt64SmallSet)->RangeMultiplier(4)->Range(2, 64); +BENCHMARK(IndexInInt32LargeSet)->RangeMultiplier(10)->Range(100, 10000000); Review Comment: Let's make the benchmarks shorter a bit? We don't need so many and so large value sets IMHO. ```suggestion BENCHMARK(IndexInInt32LargeSet)->RangeMultiplier(100)->Range(1000, 1000000); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
