js8544 commented on code in PR #36067:
URL: https://github.com/apache/arrow/pull/36067#discussion_r1238675399
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc:
##########
@@ -56,8 +56,8 @@ static void SetLookupBenchmarkString(benchmark::State& state,
template <typename Type>
static void SetLookupBenchmarkNumeric(benchmark::State& state,
const std::string& func_name,
- const int64_t value_set_length) {
- const int64_t array_length = 1 << 18;
+ const int64_t value_set_length,
+ const int64_t array_length) {
Review Comment:
done
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc:
##########
@@ -91,35 +91,52 @@ static void IsInStringLargeSet(benchmark::State& state) {
}
static void IndexInInt8SmallSet(benchmark::State& state) {
- SetLookupBenchmarkNumeric<Int8Type>(state, "index_in_meta_binary",
state.range(0));
+ SetLookupBenchmarkNumeric<Int8Type>(state, "index_in_meta_binary",
state.range(0),
+ 1 << 18);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
