bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545379841
##########
File path: cpp/src/arrow/dataset/partition.h
##########
@@ -63,13 +63,13 @@ class ARROW_DS_EXPORT Partitioning {
/// produce sub-batches which satisfy mutually exclusive Expressions.
struct PartitionedBatches {
RecordBatchVector batches;
- ExpressionVector expressions;
+ std::vector<Expression> expressions;
Review comment:
The other `$XVector` typedefs indicate a `vector<shared_ptr<$X>>`
whereas ExpressionVector would be `vector<$X>` I'm fine with putting it back
but it seemed against the unwritten convention
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
