bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545382248
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -62,10 +63,7 @@ class ARROW_DS_EXPORT ScanOptions {
std::shared_ptr<ScanOptions> ReplaceSchema(std::shared_ptr<Schema> schema)
const;
// Filter
- std::shared_ptr<Expression> filter = scalar(true);
-
- // Evaluator for Filter
- std::shared_ptr<ExpressionEvaluator> evaluator;
+ Expression filter2 = literal(true);
Review comment:
Yes, while refactoring I had both `filter` and `filter2`. I will rename
it back to `filter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
