bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545382579
##########
File path: cpp/src/arrow/dataset/scanner_test.cc
##########
@@ -184,14 +183,26 @@ TEST_F(TestScannerBuilder, TestProject) {
TEST_F(TestScannerBuilder, TestFilter) {
ScannerBuilder builder(dataset_, ctx_);
- ASSERT_OK(builder.Filter(scalar(true)));
- ASSERT_OK(builder.Filter("i64"_ == int64_t(10)));
- ASSERT_OK(builder.Filter("i64"_ == int64_t(10) || "b"_ == true));
-
- ASSERT_RAISES(TypeError, builder.Filter("i64"_ == int32_t(10)));
- ASSERT_RAISES(Invalid, builder.Filter("not_a_column"_ == true));
- ASSERT_RAISES(Invalid,
- builder.Filter("i64"_ == int64_t(10) || "not_a_column"_ ==
true));
+ ASSERT_OK(builder.Filter(literal(true)));
+ ASSERT_OK(builder.Filter(call("equal", {field_ref("i64"),
literal<int64_t>(10)})));
Review comment:
yes, I'll replace with a call to `equal`
##########
File path: cpp/src/arrow/dataset/scanner_test.cc
##########
@@ -184,14 +183,26 @@ TEST_F(TestScannerBuilder, TestProject) {
TEST_F(TestScannerBuilder, TestFilter) {
ScannerBuilder builder(dataset_, ctx_);
- ASSERT_OK(builder.Filter(scalar(true)));
- ASSERT_OK(builder.Filter("i64"_ == int64_t(10)));
- ASSERT_OK(builder.Filter("i64"_ == int64_t(10) || "b"_ == true));
-
- ASSERT_RAISES(TypeError, builder.Filter("i64"_ == int32_t(10)));
- ASSERT_RAISES(Invalid, builder.Filter("not_a_column"_ == true));
- ASSERT_RAISES(Invalid,
- builder.Filter("i64"_ == int64_t(10) || "not_a_column"_ ==
true));
+ ASSERT_OK(builder.Filter(literal(true)));
+ ASSERT_OK(builder.Filter(call("equal", {field_ref("i64"),
literal<int64_t>(10)})));
+ ASSERT_OK(builder.Filter(
+ call("or_kleene", {
Review comment:
same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
