tustvold commented on code in PR #6778:
URL: https://github.com/apache/arrow-datafusion/pull/6778#discussion_r1243813307
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -743,9 +714,6 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
use arrow::datatypes::IntervalUnit::*;
use arrow::datatypes::TimeUnit::*;
- if lhs_type == rhs_type {
Review Comment:
This was incorrect if the types are not temporal, rather than adding a
check, I just removed it as we explicitly test the types below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
