tustvold commented on code in PR #6778:
URL: https://github.com/apache/arrow-datafusion/pull/6778#discussion_r1243817225
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -499,6 +492,7 @@ pub fn coercion_decimal_mathematics_type(
left_decimal_type: &DataType,
right_decimal_type: &DataType,
) -> Option<DataType> {
+ // TODO: Move this logic into kernel implementations
Review Comment:
I intend to this as a follow on, it is peculiar that BinaryExpr is
performing a precision/scale coercion prior to calling kernels, which then in
the case of divide then do their own scale coercion. The kernels should just be
smart enough to perform the arithmetic correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
