tustvold commented on code in PR #6778:
URL: https://github.com/apache/arrow-datafusion/pull/6778#discussion_r1243997216
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -743,30 +749,10 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
use arrow::datatypes::IntervalUnit::*;
use arrow::datatypes::TimeUnit::*;
- if lhs_type == rhs_type {
- return Some(lhs_type.clone());
- }
match (lhs_type, rhs_type) {
// interval +/-
(Interval(_), Interval(_)) => Some(Interval(MonthDayNano)),
(Date64, Date32) | (Date32, Date64) => Some(Date64),
- (Utf8, Date32) | (Date32, Utf8) => Some(Date32),
Review Comment:
This was split out into a separate string_temporal_coercion as it cannot be
used for arithmetic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
