alamb commented on code in PR #6778:
URL: https://github.com/apache/arrow-datafusion/pull/6778#discussion_r1245616100
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -25,9 +25,144 @@ use arrow::datatypes::{
use datafusion_common::DataFusionError;
use datafusion_common::Result;
-use crate::type_coercion::{is_datetime, is_decimal, is_interval, is_numeric};
+use crate::type_coercion::is_numeric;
use crate::Operator;
+/// The type signature of an instantiation of binary expression
+struct Signature {
Review Comment:
What I really dislike is overloading names of things that are different --
my feeble mind can't mentally alias / keep the two separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]