zeroshade commented on code in PR #700:
URL: https://github.com/apache/arrow-adbc/pull/700#discussion_r1258420886
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -742,39 +973,16 @@ func (c *cnxn) SetOption(key, value string) error {
switch key {
case OptionTimeoutFetch:
Review Comment:
any reason to use `fallthrough` as opposed to just having the multiple cases?
`case OptionTimeoutFetch, OptionTimeoutQuery, OptionTimeoutUpdate:` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
