zeroshade commented on code in PR #700:
URL: https://github.com/apache/arrow-adbc/pull/700#discussion_r1258433298
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -827,6 +1035,45 @@ func (c *cnxn) SetOption(key, value string) error {
return nil
}
+func (c *cnxn) SetOptionBytes(key string, value []byte) error {
+ return adbc.Error{
+ Msg: "[Flight SQL] unknown connection option",
+ Code: adbc.StatusNotImplemented,
+ }
+}
+
+func (c *cnxn) SetOptionInt(key string, value int64) error {
+ switch key {
+ case OptionTimeoutFetch:
+ fallthrough
+ case OptionTimeoutQuery:
+ fallthrough
+ case OptionTimeoutUpdate:
+ return c.timeouts.setTimeout(key, float64(value))
Review Comment:
same question as earlier, any reason to use `fallthrough` over just multiple
values in the case?
`case OptionTimeoutFetch, OptionTimeoutQuery, OptionTimeoutUpdate:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
