zeroshade commented on code in PR #700:
URL: https://github.com/apache/arrow-adbc/pull/700#discussion_r1258422992
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -742,39 +973,16 @@ func (c *cnxn) SetOption(key, value string) error {
switch key {
case OptionTimeoutFetch:
- timeout, err := getTimeoutOptionValue(value)
- if err != nil {
- return adbc.Error{
- Msg: fmt.Sprintf("invalid timeout option value
%s = %s : %s",
- OptionTimeoutFetch, value, err.Error()),
- Code: adbc.StatusInvalidArgument,
- }
- }
- c.timeouts.fetchTimeout = timeout
+ fallthrough
case OptionTimeoutQuery:
- timeout, err := getTimeoutOptionValue(value)
- if err != nil {
- return adbc.Error{
- Msg: fmt.Sprintf("invalid timeout option value
%s = %s : %s",
- OptionTimeoutFetch, value, err.Error()),
- Code: adbc.StatusInvalidArgument,
- }
- }
- c.timeouts.queryTimeout = timeout
+ fallthrough
case OptionTimeoutUpdate:
- timeout, err := getTimeoutOptionValue(value)
- if err != nil {
- return adbc.Error{
- Msg: fmt.Sprintf("invalid timeout option value
%s = %s : %s",
- OptionTimeoutFetch, value, err.Error()),
- Code: adbc.StatusInvalidArgument,
- }
- }
- c.timeouts.updateTimeout = timeout
+ return c.timeouts.setTimeoutString(key, value)
case adbc.OptionKeyAutoCommit:
autocommit := true
switch value {
case adbc.OptionValueEnabled:
+ autocommit = true
Review Comment:
is this needed since we default it to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
