zeroshade commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1261376878
##########
cpp/src/arrow/device.h:
##########
@@ -29,6 +29,25 @@
namespace arrow {
+/// \brief EXPERIMENTAL: Device type enum which matches up with C Data Device
types
+enum class DeviceType : char {
+ UNKNOWN = 0,
Review Comment:
sure, I'll add the `k` prefix. And `UNKNOWN` was my way of handling when we
don't have a device type set, i think i can update this to use your suggestion
of `std::optional` to handle this instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
