zeroshade commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1263840082
##########
cpp/src/arrow/device.h:
##########
@@ -29,6 +29,25 @@
namespace arrow {
+/// \brief EXPERIMENTAL: Device type enum which matches up with C Data Device
types
+enum class DeviceType : char {
+ UNKNOWN = 0,
+ CPU = 1,
+ CUDA = 2,
Review Comment:
It's intended that knowing which devices are stream ordered is up to the
users of the library. This is why the DeviceArray includes an sync event that
can be populated and if it isn't null it needs to be synchronized on.
Additionally after this PR, I'll be working on an interface to abstract more
of the event and synchronization for buffers. I don't think we need a separate
allocation type for async allocators, we just need to ensure that we're
consistent with the device type enums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
