zeroshade commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1265587627
##########
cpp/src/arrow/device.h:
##########
@@ -29,6 +29,25 @@
namespace arrow {
+/// \brief EXPERIMENTAL: Device type enum which matches up with C Data Device
types
+enum class DeviceType : char {
+ UNKNOWN = 0,
+ CPU = 1,
+ CUDA = 2,
Review Comment:
@felipeblazing That makes sense, I'll add that to my list of things for this
project. For now I'd prefer to hold off on adding those complexities to a
future PR rather than this one. Unless you think that this PR in and of itself
is going to be problematic without it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
